[CANOFY-113] Configure Frappe Application Settings¶

Type: Story
Epic: New Client Onboarding — Automated AWS + Frappe Provisioning
Stage key: frappe_config (pipeline stage 13 of 15)
Component: utils/onboarding_executor.py
Reference: Canofy-Frappe Production Instance Setup runbook, sections
1.1–2.2

User Story¶

As an operations engineer,
I want the freshly-provisioned site's de-branding, security, and
attachment/S3 configuration applied automatically via REST calls,
so that I no longer have to manually work through the Production
Instance Setup spreadsheet's Website Settings / System Settings / Navbar
Settings / Attachment records / S3 config steps for every client.

Description¶

Log in as Administrator (session-cookie auth — plain HTTP Basic Auth with
the account password does not work against modern Frappe REST endpoints)
and, over REST, apply:

Website Settings

• app_name = "Canofy".
• Upload branding images (App Logo, Brand Image, Splash Image, FavIcon) from
  a known local asset path and set the corresponding fields
  (app_logo, banner_image, splash_image, favicon). Skip + log
  (non-fatal) any asset file that isn't present, rather than uploading a
  placeholder as a client's real logo.

System Settings

• session_expiry = "00:30".
• Disable "login with email link".
• Enable "allow login using username".
• Set consecutive-attempt and lockout-duration limits (3 attempts, 120s
  lockout).
• Enable onboarding, enable "one session per user".
• A fresh site's language/time_zone are blank and mandatory — both must
  be set together, first, before any other System Settings field, because
  frappe.client.set_value validates the whole document on save.

Attachments — doctype name is Attachments, not "Attachment List."
Each record needs a child table (attachments_required_for, child doctype
Attachments Required For, field doctype_name) — not a flat
comma-separated string. Records to create:

S3 File Settings — doctype name is S3 File Settings, not "S3 File
Attachment." Three fields, not one:

• bucket_name = the site's own domain (site_name), not the physical
  S3 bucket name created in stage 5.
• region_name = the request's AWS region.
• folder_name = the client's client_code.

Navbar Settings

• Help dropdown: hide "About" and "Frappe Support", add an "About Canofy"
  action item (frappe.ui.toolbar.show_custom_about()).

Configuration / Prerequisites¶

• Depends on stage 10 (Administrator password) and stage 12 (site
  reachable — either via real HTTPS or the IP-override fallback).
• Branding asset PNGs must exist at a known path (e.g.
  canofy_control_centre/public/images/branding/{app_logo,brand_image, splash_image,favicon}.png) for the upload sub-step to do anything.
• Canofy Client.client_code must be set (used for folder_name).

Acceptance Criteria¶

• Every sub-step targets the real doctype names verified against a live
  site (Attachments, S3 File Settings) — not the names as originally
  spec'd in the runbook, which don't exist.
• Attachments records post with correctly structured child table rows,
  one per required doc type, not a flat string.
• Attachment Type's required-for list is scoped to Bill of Entry
  only.
• S3 File Settings has all three fields set correctly, with
  bucket_name = site domain
• A missing branding asset file is skipped with a clear log line, never
  silently ignored and never causes a placeholder upload.
• System Settings' language/time_zone are set before any other field
  on that doctype, so MandatoryError never blocks the rest of the
  stage.
• Every sub-step failure is caught and logged individually — one
  sub-step failing (e.g. an Attachments record) must not abort the
  remaining sub-steps in this stage.

Test Cases¶