[CANOFY-111] Install Custom Apps¶

Type: Story
Epic: New Client Onboarding — Automated AWS + Frappe Provisioning
Stage key: apps_install (pipeline stage 11 of 15)
Component: utils/onboarding_executor.py

User Story¶

As an operations engineer,
I want every app configured for a client automatically cloned from
GitHub and installed on their site, in the correct order,
so that client-specific functionality (canofy_tcs, s3_file_storage,
etc.) is present from day one without manual bench get-app commands per
client.

Description¶

For each row in Onboarding Request.apps_to_install (ordered by
install_order):

1. Resolve the clone target folder — normally app_name, but
   target_folder_name if requires_special_clone is set (some apps'
   repo layout doesn't match their installable app name).
2. Clone the app's repo using a GitHub PAT (from Secrets Manager, referenced
   by Onboarding Request.github_pat_key) injected into the HTTPS clone URL
   — never a PAT in plaintext in logs.
3. bench --site <site> install-app <app_name>.
4. In "AMI Image" deployment mode, skip the clone step for apps flagged
   is_standard (already baked into the golden AMI) — install-app only.

Explicit rule: frappe itself must never appear as an app to install
here. It's the base framework, already present from bench new-site in
stage 10. Any apps_to_install row named frappe (case-insensitive) must
be skipped with a clear log line, not attempted.

If an app row has no github_repo set and cloning isn't skipped for AMI
mode, the stage must fail with a specific, actionable error ("no
github_repo configured for app X") — not a generic SSM exit-status failure
that gives no clue what actually went wrong.

Configuration / Prerequisites¶

• Every app in apps_to_install must have a valid github_repo (unless
  AMI-mode-skipped) and, if private, a working github_pat_key pointing at
  a real Secrets Manager secret.
• Canofy App registry entries should exist for these apps (for
  cross-referencing special-clone folder names, default branch, etc.).

Acceptance Criteria¶

• Apps install in install_order, not an arbitrary/parallel order (some
  apps may depend on others being present first).
• frappe is never treated as an installable app.
• PAT never appears in plaintext in SSM command logs or Onboarding
  Request output.
• Special-clone apps land in the correct folder name, not the app name.
• A missing github_repo produces a specific, diagnosable error, not a
  generic failure.
• AMI-mode standard apps skip cloning but still run install-app.

Test Cases¶