[CANOFY-102] Enable EC2 Termination Protection¶

Type: Story
Epic: New Client Onboarding — Automated AWS + Frappe Provisioning
Stage key: termination_protection (pipeline stage 2 of 15)
Component: utils/aws_client.py

User Story¶

As an operations engineer,
I want every newly provisioned client instance protected against
accidental termination,
so that a stray terminate-instances call (console misclick, script
bug, bulk cleanup) can't destroy a live client's server.

Description¶

Immediately after the instance is running, enable
DisableApiTermination on it via ModifyInstanceAttribute. This must run
early in the pipeline — before any destructive-capable stage — so that even
if a later stage fails badly, the instance itself is safe from accidental
deletion.

Note the trade-off this creates deliberately: if onboarding fails
downstream and the instance needs to be discarded, an engineer must
explicitly disable termination protection first. This is intentional — see
Test Case TC-3.

Configuration / Prerequisites¶

• Depends on stage 1 (aws_provision) having produced a valid
  instance_id in the pipeline context.

Acceptance Criteria¶

• DisableApiTermination is true on the instance immediately after
  this stage runs.
• Stage fails clearly if instance_id is missing from context (defensive
  check — should never happen if stage ordering is correct, but must not
  silently no-op).

Test Cases¶