Feature #161
openFeature #42: Delivery Note Implementation
Requested By and Customer Contact Person Details fields
0%
Description
Requested By and Customer Contact Person Details fields¶
Two new Delivery Challan fields captured in the wizard's additional details and shown on Review and Approval.
1. Summary¶
Feedback asked for a Requested By field and a Customer Contact Person Details field on the Delivery Challan, entered in the wizard's additional details section. Both were added to the DocType and the wizard, shown in the Review and Approval summaries, and laid out on their own full-width rows so a tall field no longer stretches the short ones next to it. On 16 Sep the user changed Customer Contact Person Details from Small Text to Data; that change is in the working tree and not yet committed.
2. Requirement¶
| # | Requirement | Source | Status |
|---|---|---|---|
| R1 | New Data field Requested By | User, 15 Sep | Done |
| R2 | Customer Contact Person Details, Small Text, in the wizard's additional details | User, 15 Sep | Done |
| R3 | Change Customer Contact Person Details to a Data field | User, 16 Sep | Done |
3. Decisions¶
| Decision | Options considered | Why this one | Date |
|---|---|---|---|
| Short fields share a row; the tall field gets its own full-width row | Keep one grid | A tall Small Text field stretched its neighbours and left empty space | 2026-09-15 |
| Contact person becomes a Data field | Keep Small Text | User request | 2026-09-16 |
4. Logic & Workflow¶
Requested By and Customer Contact Person Details are entered in the Movement step's additional details, saved on the Delivery Challan through MOVEMENT_FIELDS in wizard/dc_wizard.py, and shown on Review and Approval.
5. Files & Components Changed¶
| File / DocType / Fixture | Type | Change | Purpose |
|---|---|---|---|
| canofy_custom_eh/canofy_custom_eh/doctype/delivery_challan/delivery_challan.json | DocType | Changed |
requested_by (Data), customer_contact_person_details (Small Text, then Data) |
| canofy_custom_eh/canofy_custom_eh/page/delivery_challan_wizard/delivery_challan_wizard.js | Page JS | Changed | Fields in additional details; summaries |
| canofy_custom_eh/wizard/dc_wizard.py | Python | Changed | Maps both fields onto the document |
| canofy_custom_eh/public/css/dc_wizard.css | CSS | Changed | Full-width rows |
6. Configuration & Deployment¶
DocType change: run bench --site <site> migrate. The Data change on 16 Sep is a field type change on customer_contact_person_details.
7. Testing¶
| Test | Data / Site | Expected | Actual | Status |
|---|---|---|---|---|
| Additional details layout and Data field | E2E suite, 5 Oct | TC-048 passes | Pass | PASS |
| Values flow to Review and the saved document | E2E suite, 5 Oct | TC-049 passes | Pass | PASS |
8. Known Limitations & Open Items¶
- Existing documents keep their Small Text content; Not confirmed whether any values longer than a Data field exist on the site.
9. Status¶
| Item | Value |
|---|---|
| Branch | claude/delivery-challan-wizard-bcb464 |
| Commits |
9c93020 (fields, 16 Sep). The Data type change is uncommitted |
| PR | Not confirmed |
| Version | Not confirmed |
| Deployed to | Local dev site only |
10. References¶
- Related:
dc-wizard-phase-merge,dc-print-format-changes
Pushed to Redmine on 19 Oct 2026, 14:52 from dc-wizard-requested-by-contact_20261016-1656.md (README created 19 Oct 2026, 14:52).
Files
No data to display